Add enable extensions for ray queries and ray query vertex returns.#8545
Merged
cwfitzgerald merged 3 commits intogfx-rs:trunkfrom Nov 18, 2025
Merged
Add enable extensions for ray queries and ray query vertex returns.#8545cwfitzgerald merged 3 commits intogfx-rs:trunkfrom
cwfitzgerald merged 3 commits intogfx-rs:trunkfrom
Conversation
cwfitzgerald
requested changes
Nov 18, 2025
Member
cwfitzgerald
left a comment
There was a problem hiding this comment.
Could you add some tests for this in wgsl_errors.rs
81a809a to
7245701
Compare
cwfitzgerald
approved these changes
Nov 18, 2025
|
|
||
| #### General | ||
|
|
||
| - Require new enable extensions when using ray queries and position fetch (`wgpu_ray_query`, `wgpu_ray_query_vertex_return`). By @Vecvec in [#8545](https://github.com/gfx-rs/wgpu/pull/8545). |
Member
There was a problem hiding this comment.
thought: Would a BREAKING callout be helpful?
robtfm
added a commit
to bevyengine/naga_oil
that referenced
this pull request
Jan 22, 2026
This is a working naga 28 update. I noticed some tests haven't passed (specifically cargo test --all-features) since before 0.14, so this PR doesn't attempt to make them pass. ## enumerate_adaptors `instance.enumerate_adapters` is async now (and available on webgpu): gfx-rs/wgpu#8230 . more details in the wgpu release notes. ## ControlBarrier & MemoryBarrier Barrier was split in two to support MemoryBarriers: gfx-rs/wgpu#7630 From the PR, it seems like falling back to ControlBarrier is fine so that's what I did. ## Ray Query enable ray queries require `enable wgpu_ray_query;`: gfx-rs/wgpu#8545 This doesn't currently seem to make it through, and the relevant test fails. ## ImageAtomic Image atomics were added in gfx-rs/wgpu#6706 ## Mesh Shaders Mesh shaders are a major feature of wgpu 28, ~~but I've set their fields to None here in the interest of doing an upgrade and not a feature add at the same time~~ https://github.com/gfx-rs/wgpu/releases/tag/v28.0.0 update: I found some time and built a wgpu mesh/task shader demo and used that to validate some of the mesh shader functionality. I've used this to successfully compile a task shader with naga-oil and run it, but there's still something missing from the mesh shader module output here. --------- Co-authored-by: robtfm <50659922+robtfm@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections
As discussed on matrix
Description
Adds an enable extension for ray tracing (
wgpu_ray_query), because ray queries came in before wgpu supported enable extensions.Testing
adds enable to the ray tracing tests
Squash or Rebase?
squash
Checklist
cargo fmt.cargo clippy --tests.cargo xtask testto run tests.CHANGELOG.mdentry.